Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fedora embree package #10439

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

0HyperCube
Copy link
Contributor

@0HyperCube 0HyperCube commented Dec 26, 2024

Fix embree package name to install for Fedora. You need embree 4 to compile Godot from source while using system libraries. Embree4 appears to be packaged as embree-devel. https://packages.fedoraproject.org/pkgs/embree/embree-devel/

If the previously suggested version of embree is installed, the following compile error occurs:

In file included from modules/raycast/lightmap_raycaster_embree.cpp:33:
modules/raycast/lightmap_raycaster_embree.h:40:10: fatal error: embree4/rtcore.h: No such file or directory
   40 | #include <embree4/rtcore.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

@mhilbrunner mhilbrunner added bug area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem labels Dec 26, 2024
@mhilbrunner mhilbrunner added this to the 4.3 milestone Jan 3, 2025
@mhilbrunner mhilbrunner merged commit 73d92a8 into godotengine:master Jan 3, 2025
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug cherrypick:4.3 topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants